From 31f81975e24948f176586f448d1861b68794fec6 Mon Sep 17 00:00:00 2001 From: Yusuke Matsubara Date: Mon, 23 Dec 2013 21:31:41 +0900 Subject: [PATCH] Don't escape HTML title of Special:Contributions for newbies This is a correction regarding the call of "->plain". MediaWiki:pagetitle may contain variables (such as {{SITENAME}}) to be parsed, so it should not be treated as plain text. MediaWiki:sp-contributions-newbies-title appears to be plain text only. Change-Id: Ia6c0d955fb789535104956be9a00ce432aabe9e1 --- includes/specials/SpecialContributions.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php index 551b9727e8..3af86f08c3 100644 --- a/includes/specials/SpecialContributions.php +++ b/includes/specials/SpecialContributions.php @@ -98,10 +98,10 @@ class SpecialContributions extends SpecialPage { $this->getSkin()->setRelevantUser( $userObj ); } else { $out->addSubtitle( $this->msg( 'sp-contributions-newbies-sub' ) ); - $out->setHTMLTitle( - $this->msg( 'pagetitle', $this->msg( 'sp-contributions-newbies-title' ) ) - ->inContentLanguage()->plain() - ); + $out->setHTMLTitle( $this->msg( + 'pagetitle', + $this->msg( 'sp-contributions-newbies-title' )->plain() + )->inContentLanguage() ); } if ( ( $ns = $request->getVal( 'namespace', null ) ) !== null && $ns !== '' ) { -- 2.20.1